Support Schema version 14 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema version of the manifest has increased to 14 now. The sqldiff didn't show any special: ``` sqldiff /Users/askorczyk/src/GitHub/go-jwlm/model/data/userData.db /Users/askorczyk/Downloads/UserdataBackup_2023-08-13_iPhone/userData.db UPDATE LastModified SET LastModified='2023-08-13T10:07:57Z' WHERE rowid=1; UPDATE grdb_migrations SET identifier='v14' WHERE rowid=1; ``` So it should be save to simply update the schema version without adjusting the model.
Instead of just saying that the version is incompatible, it is communicated if the received version is either too old or too new.
AndreasSko
added a commit
to AndreasSko/ios-jwlm
that referenced
this pull request
Aug 13, 2023
With the latest JW Library update the schema version of the manifest has increased to 14 now. Also see AndreasSko/go-jwlm#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest JW Library update the schema version of the manifest has increased to 14 now. The sqldiff didn't show
anything special:
So it should be safe to simply update the schema version without adjusting the model.
Other changes: More granular error message on manifest validation
Instead of just saying that the version is incompatible, it is communicated if the received version is either too old or too new.