Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpiceNOTENOUGHDATA2 exception #466

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

cgobat
Copy link
Contributor

@cgobat cgobat commented Jun 27, 2023

I encountered a SPICE(NOTENOUGHDATA2) error which had no corresponding exception class in SpiceyPy. This PR adds it to exceptions.py.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #466 (a716650) into main (141fe4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          13       13           
  Lines       15633    15635    +2     
=======================================
+ Hits        15612    15614    +2     
  Misses         21       21           
Impacted Files Coverage Δ
src/spiceypy/utils/exceptions.py 100.00% <100.00%> (ø)

@AndrewAnnex
Copy link
Owner

LGTM! thanks @cgobat

@AndrewAnnex AndrewAnnex merged commit 498989a into AndrewAnnex:main Jun 27, 2023
@cgobat cgobat deleted the add-spicenotenoughdata2 branch June 29, 2023 01:21
AndrewAnnex added a commit that referenced this pull request Aug 31, 2023
## [6.0.0] - 2023-08-30
Fixed several major typos and fortran array ordering issues in tkfram, zzdynrot as well as failing tests on arm64 macos. 
### Added
- SpiceNOTENOUGHDATA2 exception #466
- Context manager for SPICE kernels #458
- CITATION.cff file
- DeprecationWarning for zzdynrot

### Changed
- tkfram_c now used in tkfram wrapper function
- updated setup.cfg
- type hints for sincpt to be more correct

### Deprecated
- python 3.6
- python 3.7

### Removed
- codecov as a dependency in dev

### Fixed
- fixed zzdynrot and tkfram return matrix element ordering
- typo in exceptions.rst #459
- fixed test test_sphlat
- fixed sphlat to use correct libspice function call
- fixed tests for dskx02, dskxsi, gfsntc for arm64 macos floating point issues #470
- fixed typo in test_oscelt and test_oscltx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants