Skip to content

Commit

Permalink
Fix args for webhook deployment (kubernetes-sigs#4202)
Browse files Browse the repository at this point in the history
* Fix args for webhook deployment

The upfront bullet point resulted in `- ""` and could brake the webhook container.

* Add changeloog
  • Loading branch information
webwurst authored and AndrewCharlesHay committed Feb 7, 2024
1 parent 9c3aa75 commit 61215d2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions charts/external-dns/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Fixed

- Fix args for webhook deployment. ([#4202](https://github.com/kubernetes-sigs/external-dns/pull/4202))

## [v1.14.2] - 2024-01-22

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion charts/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ spec:
{{- end }}
{{- with .args }}
args:
- {{ toYaml . | nindent 12 }}
{{- toYaml . | nindent 12 }}
{{- end }}
ports:
- name: http-webhook
Expand Down

0 comments on commit 61215d2

Please sign in to comment.