Skip to content

Commit

Permalink
Enable default lighting (#224)
Browse files Browse the repository at this point in the history
* Enable default lighting

* changelog

* type: differnet -> different
  • Loading branch information
Pilot-Marc authored and intere committed Oct 10, 2019
1 parent 5804ee5 commit a9e9a5b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions ARKit+CoreLocation/POIViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ extension POIViewController {
sceneLocationView.addLocationNodeWithConfirmedLocation(locationNode: $0)
}
}

// There are many different ways to add lighting to a scene, but even this mechanism (the absolute simplest)
// keeps 3D objects fron looking flat
sceneLocationView.autoenablesDefaultLighting = true

}

/// Builds the location annotations for a few random objects, scattered across the country
Expand Down
2 changes: 1 addition & 1 deletion Sources/ARKit-CoreLocation/Nodes/LocationNode.swift
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ open class LocationNode: SCNNode {

onCompletion()
}

/// Converts distance from meters to SCNKit rendering order
/// Constant multiplier eliminates flicker caused by slight distance variations
/// Nodes with greater rendering orders are rendered last
Expand Down
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog
- 1.2.2
- [PR #224 - Enable default lighting ](https://github.com/ProjectDent/ARKit-CoreLocation/pull/224)
- [PR #220 - Render distant nodes behind closer nodes ](https://github.com/ProjectDent/ARKit-CoreLocation/pull/220)
- 1.2.1
- [PR #207 - Addresses Issue #136 - ARCL lacks CI ](https://github.com/ProjectDent/ARKit-CoreLocation/pull/207)
Expand Down

0 comments on commit a9e9a5b

Please sign in to comment.