Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public warnings #180

Closed
wants to merge 1 commit into from
Closed

Fix public warnings #180

wants to merge 1 commit into from

Conversation

matsoftware
Copy link
Contributor

@matsoftware matsoftware commented May 16, 2019 •
edited
Loading

Background

Remove warnings on public methods in extensions.

Breaking Changes

No public API changes.

Meta

  • Tied to Version Release(s):

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@intere intere self-assigned this May 17, 2019
@intere
Copy link
Collaborator

intere commented May 17, 2019

@matsoftware - thanks for your PR. I'm going to close it in lieu of #181 - which targets the develop branch. @aaronbrethorst and I are working to get that set as the default branch.

@intere intere closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@intere intere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matsoftware @intere