Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: update to use php8 #67

Merged
merged 1 commit into from
Jul 3, 2022
Merged

docker: update to use php8 #67

merged 1 commit into from
Jul 3, 2022

Conversation

mattburchett
Copy link
Collaborator

No description provided.

@mattburchett
Copy link
Collaborator Author

mattburchett commented Jul 1, 2022 •
edited
Loading

@AndrewPaglusch This should fix the issues that's causing Dependabot to fail it's checks in #66.

@modem7
Copy link
Contributor

modem7 commented Jul 3, 2022 •
edited
Loading

@mattburchett - Would it be worthwhile editing the original notes with "Fixes #61" so it links appropriately and auto closes when merged?

@AndrewPaglusch
Copy link
Owner

I just tested this. FlashPaper seems to be working well on PHP8. Closes #61 (not sure if this will work from a comment)

@AndrewPaglusch
Copy link
Owner

Whoops. Maybe I should merge first

@AndrewPaglusch AndrewPaglusch reopened this Jul 3, 2022
@AndrewPaglusch AndrewPaglusch merged commit dd979aa into master Jul 3, 2022
@AndrewPaglusch AndrewPaglusch deleted the matt/php8 branch July 3, 2022 03:29
@modem7 modem7 mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewPaglusch AndrewPaglusch AndrewPaglusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattburchett @modem7 @AndrewPaglusch