Fix CRevModel process function loop stride #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the decompilation result of
CRevModel_R::ProcessReplace
, the for loop should process two elements in the buffer array each time, rather than iterating over each element.This also explains why
Reverberation::Process
setsbufR = bufL + 1
.This MIGHT fix the reverberation effect, although I haven't tried the change on my phone (haven't set up a Android build environment yet).
Below is my decompilation result with Ghidra for reference: