Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Ability to pause/unpause giveaways #269

Merged
merged 30 commits into from
Jun 23, 2021
Merged

✨Ability to pause/unpause giveaways #269

merged 30 commits into from
Jun 23, 2021

Conversation

Lebyy
Copy link
Contributor

@Lebyy Lebyy commented Apr 29, 2021

No description provided.

Lebyy added 2 commits April 29, 2021 05:42
1. Added functionality
2. Bumped discord.js version
3. Edited typings and examples to work with the new updates
@Lebyy Lebyy changed the base branch from master to develop April 29, 2021 09:00
@Nico105
Copy link
Collaborator

Nico105 commented May 17, 2021

I wonder, should there be an option in the pause function to overwrite the pauseOptions object?

@Lebyy
Copy link
Contributor Author

Lebyy commented May 17, 2021

I wonder, should there be an option in the pause function to overwrite the pauseOptions object?

Sure we can have it

@Nico105 Nico105 added the enhancement New feature or request label May 21, 2021
Copy link
Contributor

@WiseDevHelper WiseDevHelper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Wise <45759535+WiseDevHelper@users.noreply.github.com>
Copy link
Contributor Author

@Lebyy Lebyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, committed them👍

@Nico105
Copy link
Collaborator

Nico105 commented Jun 4, 2021

Is the separate generateEmbed function really needed? Since I don't think you would allign the other messages in a different way just because the gaw is paused.

README.md Outdated Show resolved Hide resolved
examples/simple.js Outdated Show resolved Hide resolved
examples/simple.js Outdated Show resolved Hide resolved
src/Constants.js Outdated Show resolved Hide resolved
src/Constants.js Outdated Show resolved Hide resolved
src/Giveaway.js Outdated Show resolved Hide resolved
src/Manager.js Outdated Show resolved Hide resolved
src/Giveaway.js Outdated Show resolved Hide resolved
src/Manager.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Lebyy Lebyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Alrighty

Co-authored-by: Nico <63612668+Nico105@users.noreply.github.com>
@Lebyy Lebyy requested a review from Nico105 June 7, 2021 11:09
src/Giveaway.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nico105 Nico105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems finished to me. If anything is open lmk.

README.md Outdated Show resolved Hide resolved
@Nico105 Nico105 merged commit 9946f20 into Androz2091:develop Jun 23, 2021
@Lebyy
Copy link
Contributor Author

Lebyy commented Jun 23, 2021

Thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants