feat: add Giveaway param in exemptmember #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nico105
reviewed
Apr 16, 2022
|
btw for consistency you could also add the param for bonusEntry functions, if you want. |
Nico105
reviewed
Apr 16, 2022
I haven't checked any bonus entry-related codes yet so idk how it works and I don't have time to check all the bonus entries related codes. If anyone else is interested then go-ahead |
np. i will do it when i have time then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pr adds
Giveawayparam inexemptMembersfunction.Ik we've
new Function(), where we can accessthis, but when usingnew Function()all our javascript code becomes a string and that's why our ide/typescript can't show errors. Also, everyone doesn't know how to makenew Function()async.Status