Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'class_icon' method because we could not use an icon named 'class' #26

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

ykpythemind
Copy link
Contributor

I could not use this icon named 'class', because name was duplicated with Object#class method.

https://material.io/tools/icons/?search=class&icon=class&style=baseline

So, calling mi.class_icon now sets the class icon.

@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage increased (+0.1%) to 98.618% when pulling 49db5a3 on ykpythemind:class_icon into c92a255 on Angelmmiguel:master.

@Angelmmiguel Angelmmiguel self-requested a review July 9, 2018 09:49
Copy link
Owner

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, icon names are a problem with the current approach of method_missing. From time to time the gem faces this kind of issues.

Thank you very much for your PR! 👍

@Angelmmiguel Angelmmiguel self-assigned this Jul 11, 2018
@Angelmmiguel Angelmmiguel merged commit f04cbda into Angelmmiguel:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants