Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characters are overlapping on layer transition #206

Closed
Annoraaq opened this issue Oct 12, 2021 · 1 comment
Closed

Characters are overlapping on layer transition #206

Annoraaq opened this issue Oct 12, 2021 · 1 comment
Assignees
@Annoraaq
Labels
bug Something isn't working

Comments

@Annoraaq
Copy link
Owner

If a characters height exceeds the tile height, it will be overlapped by another character that is one charLayer higher. That is intended behaviour in most situations, but can be unexpected in situations like stairs with a layer transition:

Screenshot 2021-10-12 at 18 23 52
@Annoraaq Annoraaq added the bug Something isn't working label Oct 12, 2021
@Annoraaq Annoraaq self-assigned this Oct 12, 2021
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 change depth sorting
c69ded8
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 introduce GridSprite
ba4ab17
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 wip remove phaser sprite from char
629cdc7
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 remove phaser sprite from char
8616e8f
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 refactor blocking
0d55ddc
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 remove tileSize from char
3bce776
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206 refactor tileSize
c34fdf5
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206: refactor movements
1ddaf69
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206: add obs test
5499f4c
Annoraaq added a commit that referenced this issue Nov 3, 2021
@Annoraaq
#206: add targetMovement obs test
c2c1b4e
Annoraaq added a commit that referenced this issue Nov 4, 2021
@Annoraaq
#206 refactor
104e281
Annoraaq added a commit that referenced this issue Nov 5, 2021
@Annoraaq
#206 refactor
2708bce
Annoraaq added a commit that referenced this issue Nov 5, 2021
@Annoraaq
#206 refactor random
77e2821
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 move method
6d162ee
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 move method
5f4b1f9
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 remove unused method
f02c820
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 move method
31cd9e6
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 remove class
c092142
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 move method
7634957
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 remove cloning
850944b
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 remove unused method
4951a2f
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 move method
aa7c2ee
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 refactor
9f0c0c5
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 refactor movement
8620959
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 refactor
2a7a10d
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 refactor
4919f78
Annoraaq added a commit that referenced this issue Nov 7, 2021
@Annoraaq
#206 fix movement
5f8ea52
Annoraaq added a commit that referenced this issue Nov 14, 2021
@Annoraaq
#206 introduce overlaysprite
0ca0d38
Annoraaq added a commit that referenced this issue Nov 14, 2021
@Annoraaq
#206 add more unit tests
91b7e79
Annoraaq added a commit that referenced this issue Nov 14, 2021
@Annoraaq
#206 add tests for z-index of overlay
299a4c7
Annoraaq added a commit that referenced this issue Nov 14, 2021
@Annoraaq
#206 make layer overlay configurable
d3012bb
Annoraaq added a commit that referenced this issue Nov 15, 2021
@Annoraaq
#206 add licence
64f2df6
Annoraaq added a commit that referenced this issue Nov 15, 2021
@Annoraaq
#206 add license
106051e
Annoraaq added a commit that referenced this issue Nov 16, 2021
@Annoraaq
#206 add license
deca126
Annoraaq added a commit that referenced this issue Nov 22, 2021
@Annoraaq
#206 refactor
09c8b0d
Annoraaq added a commit that referenced this issue Nov 22, 2021
@Annoraaq
#206 refactor
e723cac
Annoraaq added a commit that referenced this issue Nov 22, 2021
@Annoraaq
#206 remove comment
b35d845
Annoraaq added a commit that referenced this issue Nov 22, 2021
@Annoraaq
#206 fix layers
4caa70c
Annoraaq added a commit that referenced this issue Nov 24, 2021
@Annoraaq
#206 refactor layers
a8a407d
Annoraaq added a commit that referenced this issue Nov 24, 2021
@Annoraaq
#206 remove unused test
1785a86
Annoraaq added a commit that referenced this issue Nov 24, 2021
@Annoraaq
Merge pull request #209 from Annoraaq/feature/#206-correct-overlapping
b32703c 
Feature/#206 correct overlapping
@Annoraaq
Copy link
Owner Author

partially resolved with the layerOverlay feature in version 2.11.0

However, conceptually there is no clear solution to this. For more infos see: https://annoraaq.github.io/grid-engine/features/layer-overlay.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annoraaq Annoraaq

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Annoraaq