Improvements to render style support and selection #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Added `TextImage` and `GraphicsImage` (subclasses of `BaseImage`) in `.image.common`. - Add: Now exporting `TextImage` and `GraphicsImage` from `.image`. - Change: Moved `_pixel_ratio` definitions into category baseclasses and turned `BaseImage._pixel_ratio` into an abstract property. - Change: Changed the baseclass of `TermImage` to `TextImage`. - Change: Changed the baseclass of `KittyImage` to `GraphicsImage`. - Change: Updated docs, docstrings and comments.
AnonymouX47
added
documentation
- Add: Added render style support validation in `GraphicsImage.__init__()`. - Change: Updated style-dependent tests. - Change: All graphics-based render styles now raise `TermImageException` at instantiation if not supported in the active terminal.
- Add: Added '--force-style' CL option to force unsupported render styles.
- Fix: Handled selection of unsupported and partially supported render styles. - Fix: Emmited support detection APCs are now "erased". - Change: Support checks for automatic selection now occur only when "auto" style is chosen. - Eliminates unneccesary render style support checks. - Change: Changed `-S` from `--scroll` to `--style`.
AnonymouX47
force-pushed
the
render-styles
branch
2 times, most recently
from
45d08f7 to
f7816bc
Compare
AnonymouX47
added
the
cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextImageandGraphicsImage(subclasses ofBaseImage) in.image._pixel_ratiodefinitions into category baseclasses and turnsBaseImage._pixel_ratiointo an abstract property.TermImagetoTextImage.KittyImagetoGraphicsImage.--force-style.-Sfrom--scrollto--style.