Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term-image to respect XDG Base Directories Specification #2

Closed
cmcallister opened this issue Jul 18, 2022 · 1 comment
Closed

term-image to respect XDG Base Directories Specification #2

cmcallister opened this issue Jul 18, 2022 · 1 comment
Labels
config Related to viewer Configuration enhancement New feature / Improvement suggestion or request linux

Comments

@cmcallister
Copy link

cmcallister commented Jul 18, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently term-image stores and writes configuration files to $HOME/.term_image/

Describe the solution you'd like
If the system has XDG_CONFIG_HOME set, please place configurations there (there may be other considerations, see XDG Base Directories Specification)

Describe alternatives you've considered
Thought about a symlink, but that still leaves another line of output when listing the home directory
@cmcallister cmcallister added the enhancement New feature / Improvement suggestion or request label Jul 18, 2022
@AnonymouX47 AnonymouX47 added config Related to viewer Configuration cli Related to the CLI mode tui Related to the TUI (and TUI mode) linux and removed cli Related to the CLI mode tui Related to the TUI (and TUI mode) labels Jul 29, 2022
AnonymouX47 referenced this issue in AnonymouX47/term-image Aug 22, 2022
@AnonymouX47
[config] Implemented support for XDG Base Dirs
ea88da0 
- Add: `$XDG_CONFIG_HOME` and `$XDG_CONFIG_DIRS` are now searched for user config files.
- Add: Added `load_xdg_config()`, `xdg_config_file` and `user_config_file` in `.config`.
- Change: Config files are no longer written into or searched for in `$HOME/.term_image/`.

Refs: #63
@AnonymouX47 AnonymouX47 mentioned this issue Aug 22, 2022
Merged
AnonymouX47 referenced this issue in AnonymouX47/term-image Mar 27, 2023
@AnonymouX47
refactor: Use tempfile for URL-sourced images
1750e75 
- Change: Store downloaded image files in an OS/env-specific temporary
  directory.
- Change: Remove from planned features.

Refs: #63
@AnonymouX47 AnonymouX47 transferred this issue from AnonymouX47/term-image Apr 16, 2023
AnonymouX47 added a commit that referenced this issue Apr 19, 2023
@AnonymouX47
feat: Use XDG_STATE_HOME for "log file" default
ab971d6 
- Change: Change default value of "log file" config option to `"$XDG_STATE_HOME/termvisage/log"`.
- Change: Update "log file" documentation.
- Change: Update sample default config file.

Refs: #2
@AnonymouX47
Copy link
Owner

Finally putting this to rest. 😃

I've updated every aspect of the tool that used ~/.term_image to now use XDG Base Directories (or system/user-specific directories in the case of temporary files).

I'm sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config Related to viewer Configuration enhancement New feature / Improvement suggestion or request linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmcallister @AnonymouX47