revise error message for better upgrading (keras-team#776)

Co-authored-by: Haifeng Jin <haifeng-jin@users.noreply.github.com>
Anselmoo · Dec 4, 2022 · 41693aa · 41693aa
1 parent 5cbaa1a
commit 41693aa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/keras_tuner/engine/tuner_test.py b/keras_tuner/engine/tuner_test.py
@@ -1106,7 +1106,10 @@ def run_trial(self, trial, *fit_args, **fit_kwargs):
                 trial.trial_id, {"loss": min(history.history["loss"])}
             )
 
-    with pytest.raises(errors.FatalTypeError, match="return the metrics directly"):
+    with pytest.raises(
+        errors.FatalTypeError,
+        match="`self\.oracle\.update_trial\(trial_id, metrics\)`",
+    ):
         assert_found_best_score(tmp_path, MockHyperModel(), MyTuner)
 
 

diff --git a/keras_tuner/engine/tuner_utils.py b/keras_tuner/engine/tuner_utils.py
@@ -301,9 +301,11 @@ def validate_trial_results(results, objective, func_name):
         )
         if func_name == "Tuner.run_trial()":
             error_message += (
-                "\nIf you are calling Oracle.update_trial() "
-                "in Tuner.run_trial() to report the metrics, "
-                "please remove the call and return the metrics directly."
+                "\nIf you are calling "
+                "`self.oracle.update_trial(trial_id, metrics)` "
+                "in `Tuner.run_trial()` to report the metrics, "
+                "please remove the call and `return metrics` "
+                "in `Tuner.run_trial()` instead."
             )
         raise errors.FatalTypeError(error_message)