Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to handle exploded data #1282

Closed
vladtr opened this issue Jun 13, 2023 · 1 comment
Closed

Add support to handle exploded data #1282

vladtr opened this issue Jun 13, 2023 · 1 comment

Comments

@vladtr
Copy link
Contributor

vladtr commented Jun 13, 2023

As it was noted in #1280 regarding get_transaction_id api call by @heifner, following are desirable set of improvements in a way data / hex_data is being handled.

Copy/pasting original description from mentioned above PR:

  • As part of this effort, I think we should support exploded data.
  • As part of this effort, I think we should provide optional support for exploded data in cleos. For cleos, this should be optional as a user may want to prevent cleos from communicating with nodeos. Could support the option of providing abi. See --unpack-action-data option --abi-file.
  • To increase security, if both "data" and "hex_data" are provide then we should verify they are equivalent.
@bhazzard
Copy link

This was initially added to track potential additional logic to protect the user from being deceived by false transaction json. After discussion, we determined that these additional protections are not necessary based on the intended purpose of the get_transaction_id api call.

@bhazzard bhazzard closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Jun 15, 2023
@bhazzard bhazzard removed the triage label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants