[4.0] if actions.data & actions.hex_data provided, use the hex_data in api call get_transaction_id #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Jun 13, 2023
| @@ -41,6 +41,45 @@ parse_params<chain_apis::read_only::get_transaction_status_params, http_params_t | |||
| } | |||
| } | |||
|
|
|||
| // if actions.data & actions.hex_data provided, use the hex_data since only currently support unexploded data | |||
There was a problem hiding this comment.
- As part of this effort, I think we should support exploded
data. - As part of this effort, I think we should provide optional support for exploded
datain cleos. For cleos, this should be optional as a user may want to prevent cleos from communicating with nodeos. Could support the option of providing abi. See--unpack-action-dataoption--abi-file. - To increase security, if both "data" and "hex_data" are provide then we should verify they are equivalent.
- Please add some tests.
There was a problem hiding this comment.
I added a separate issue to include exploded data handling improvements:
#1282
heifner
reviewed
Jun 14, 2023
heifner
reviewed
Jun 14, 2023
…lopeIO/leap into GH-1197-get-transaction-id-hex-data
greg7mdp
reviewed
Jun 14, 2023
greg7mdp
reviewed
Jun 14, 2023
greg7mdp
approved these changes
Jun 14, 2023
greg7mdp
reviewed
Jun 14, 2023
| } | ||
|
|
||
| try { | ||
| fc::variant trx_var = fc::json::from_string( body ); |
There was a problem hiding this comment.
Is it an issue that we don't use a yield function to limit the time spent in the deserialization? never mind!
heifner
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that logic for handling transaction as part of get_transaction_id request was different in cleos and chain_api_plugin. Resolves #1197
This PR makes a change to a logic of get_transaction_id handler as such:
caveat here that there is a few lines of code duplication between chain_api_plugin and cleos, but this is probably safest way to address initial issue without dangers of changing abi serializer