Test failure: plugin_test

[heifner]

https://github.com/AntelopeIO/leap/actions/runs/5616780429/job/15219829929

terminate called after throwing an instance of 'eosio::chain::block_validate_exception'
  what():  Block exception

[greg7mdp]

I think it may be related to this change (I made) in include/appbase/application_instance.hpp:42, which was applied when you caught appbase to tip. It was part of my plugin startup/shutdown issue which had changes both in appbase and leap, but only the appbase PR was merged to main.

I'm looking into the issue.

[heifner]

Another failure: https://github.com/AntelopeIO/leap/actions/runs/5622859188/job/15236444961

warn  2023-07-21T13:33:39.792 plugin_te chain_plugin.cpp:1110         plugin_initialize    ] 3100000 misc_exception: Miscellaneous exception
failed to read response from monitor process
    {}
    plugin_test  compile_monitor.cpp:326 get_connection_to_compile_monitor

appbase: exception thrown during plugin "eosio::chain_plugin" initialization.
Miscellaneous exception
terminate called after throwing an instance of 'eosio::chain::misc_exception'
  what():  Miscellaneous exception

[heifner]

Looks like the terminate is because we are not joining the app_thread in test_read_only_trx.cpp on exception.

diff --git a/tests/test_read_only_trx.cpp b/tests/test_read_only_trx.cpp
index db36eea1e9..e8f2574fd9 100644
--- a/tests/test_read_only_trx.cpp
+++ b/tests/test_read_only_trx.cpp
@@ -111,6 +111,10 @@ void test_trxs_common(std::vector<const char*>& specific_args, bool test_disable
       plugin_promise.set_value( {app->find_plugin<producer_plugin>(), app->find_plugin<chain_plugin>()} );
       app->exec();
    } );
+   fc::scoped_exit<std::function<void()>> on_except = [&](){
+      if (app_thread.joinable())
+         app_thread.join();
+   };
 
    auto[prod_plug, chain_plug] = plugin_fut.get();
 

[greg7mdp]

Nice find. I am having a bad time trying to debug this as it happens intermittently. This definitely seems needed!

[heifner]

2 more failures: https://github.com/AntelopeIO/leap/actions/runs/5623658802/job/15238968875

[greg7mdp]

Could this change trigger the issue?