Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise max-transaction-time #1639

Closed
bhazzard opened this issue Sep 14, 2023 · 0 comments · Fixed by #1655
Closed

Raise max-transaction-time #1639

bhazzard opened this issue Sep 14, 2023 · 0 comments · Fixed by #1655
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v5.0.0-rc1

Comments

@bhazzard
Copy link

bhazzard commented Sep 14, 2023 •
edited
Loading

Change default max-transaction-time to 499

Recommend node-operators to remove max-transaction-time in their config when upgrading to 5.0.0.

To get around the read-only transaction constraints, the time limit for read-only transactions should be the minimum of max-transaction-time and the read-only window time.

This is beneficial to the EVM by allowing larger transactions. Transactions will be able to consume more gas.
@bhazzard bhazzard added this to the Leap v5.0.0-rc1 milestone Sep 14, 2023
@arhag arhag removed the triage label Sep 14, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Sep 14, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Sep 15, 2023
heifner added a commit that referenced this issue Sep 15, 2023
@heifner
GH-1639 Change default max-transaction-time from 30 to 499
ae1a89c
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Execute read-only trxs only on read-only threads
494fbae
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Add <optional> include
fd232b2
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Add <optional> include
2749256
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Enable contracts-console on all nodes
f038d65
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Revert changes to test
3e40394
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 read-only trxs only allowed when read-only-threads > 0
1a6631a
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Remove unneeded dependency on producer_plugin
7a7aa58
heifner added a commit that referenced this issue Sep 18, 2023
@heifner
GH-1639 Fix producer_plugin shutdown of read only threads to prevent …
1368ecd 
…SEGFAULT and deadlock.
heifner added a commit that referenced this issue Sep 19, 2023
@heifner
GH-1639 Decrease read-only-threads from 128 to 16 since ci/cd was tim…
11df9d1 
…ing out
@heifner heifner mentioned this issue Sep 19, 2023
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Sep 19, 2023
heifner added a commit that referenced this issue Sep 19, 2023
@heifner
GH-1639 Favor this over rhs for queue comparison. Also use C++20 spac…
36be3f7 
…eship comparison.
heifner added a commit that referenced this issue Sep 19, 2023
@heifner
GH-1639 Use canonical spaceship operator
d2cd84c
heifner added a commit that referenced this issue Sep 19, 2023
@heifner
GH-1639 Revert using of spaceship operator as it appears to not work …
6394011 
…on GCC 10.5
heifner added a commit that referenced this issue Sep 19, 2023
@heifner
GH-1639 Use same ec for both cancel calls
e6b8493
heifner added a commit that referenced this issue Sep 20, 2023
@heifner
GH-1639 Modify exec_pri_queue to manage the 3 priority queues instead…
8d221a7 
… of three_queue_executor.

Simplifies logic fixes issues with previous approach.
Also add some poll() calls to make sure queues have latest tasks to execute.
heifner added a commit that referenced this issue Sep 20, 2023
@heifner
GH-1639 More simplification
ae2424d
heifner added a commit that referenced this issue Sep 20, 2023
@heifner
GH-1639 fix gcc warning
e6bbaaf
heifner added a commit that referenced this issue Sep 21, 2023
@heifner
GH-1639 Additional test
a6465e6
heifner added a commit that referenced this issue Sep 22, 2023
@heifner
GH-1639 Update max-transaction-time help description
b077dc3
heifner added a commit that referenced this issue Sep 22, 2023
@heifner
GH-1639 Add init_read_threads
b012cce
heifner added a commit that referenced this issue Sep 22, 2023
@heifner
Merge pull request #1655 from AntelopeIO/GH-1639-max-trx-time-default
f16f24b 
Change default max-transaction-time
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Sep 22, 2023
heifner added a commit that referenced this issue Oct 4, 2023
@heifner
GH-1639 Fix producer_plugin shutdown of read only threads to prevent …
6af28bb 
…SEGFAULT and deadlock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Change default max-transaction-time AntelopeIO/leap
4 participants
@bhazzard @heifner @arhag @enf-ci-bot