nodeos should exit with exit code 2 if database is unclean, but doesn't

[matthewdarwin]

nodeos should exit with exit code 2 if database is unclean, but doesn't. it doesn't detect the situation cleanly and aborts with incorrect plugin error.

Steps to reproduce:

• nodeos 3.2
• make it running fine
• run pkill -9 nodeos

warn  2022-12-12T19:15:51.201 nodeos    chain_plugin.cpp:1246         plugin_initialize    ] 3110006 plugin_config_exception: Incorrect plugin configuration
Genesis state is necessary to initialize fresh blockchain state but genesis state could not be found in the blocks log. Please either load from snapshot or find a blocks log that starts from genesis.
    {}
    nodeos  chain_plugin.cpp:1046 plugin_initialize
error 2022-12-12T19:15:51.201 nodeos    main.cpp:161                  main                 ] 3110006 plugin_config_exception: Incorrect plugin configuration
Genesis state is necessary to initialize fresh blockchain state but genesis state could not be found in the blocks log. Please either load from snapshot or find a blocks log that starts from genesis.
    {}
    nodeos  chain_plugin.cpp:1046 plugin_initialize
rethrow
    {}
    nodeos  chain_plugin.cpp:1246 plugin_initialize

nodeos finished with exit code 254

[linh2931]

@matthewdarwin How did you start our node? I could not reproduce the problem in rel 3.2:

...
info  2022-12-19T13:43:29.167 nodeos    chain_plugin.cpp:968          plugin_initialize    ] Starting fresh blockchain state using genesis state extracted from blocks.log.
warn  2022-12-19T13:43:29.168 nodeos    chain_plugin.cpp:1253         plugin_initialize    ] 13 N5boost10wrapexceptISt12system_errorEE: Database dirty flag set
rethrow Database dirty flag set:
    {"what":"Database dirty flag set"}
    nodeos  chain_plugin.cpp:1253 plugin_initialize

error 2022-12-19T13:43:29.168 nodeos    main.cpp:157                  main                 ] database dirty flag set (likely due to unclean shutdown): replay required
~/work/leap-3.2/build$ echo $?
2

[stephenpdeos]

@matthewdarwin what environment are you running in? Operating system, container, host OS

[matthewdarwin]

I will check it when I have a few minutes.

[stephenpdeos]

@matthewdarwin bumping this ticket, thanks!

[heifner]

@matthewdarwin How did you start our node? I could not reproduce the problem in rel 3.2:

You have to start from a snapshot. If genesis is in the blocklog you do not get this error.

[heifner]

Cat: Logging