Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state_history_plugin unused code #593

Closed
heifner opened this issue Dec 22, 2022 · 1 comment
Closed

state_history_plugin unused code #593

heifner opened this issue Dec 22, 2022 · 1 comment
Labels
actionable bug Something isn't working

Comments

@heifner
Copy link
Member

heifner commented Dec 22, 2022

libraries/state_history/include/eosio/state_history/log.hpp state_history_log The internal thread is not used.

   std::thread                                                              thr;
   std::atomic<bool>                                                        write_thread_has_exception = false;
   std::exception_ptr                                                       eptr;
   boost::asio::io_context                                                  ctx;
   boost::asio::io_context::strand                                          work_strand{ctx};
   boost::asio::executor_work_guard<boost::asio::io_context::executor_type> work_guard =
       boost::asio::make_work_guard(ctx);
   std::recursive_mutex                                                     mx;

The thr and ctx is not used for anything after creation. The mx is not protecting anything that needs protection.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 22, 2022
@heifner heifner added bug Something isn't working actionable and removed triage labels Dec 22, 2022
cmadh pushed a commit to cmadh/leap that referenced this issue Jan 2, 2023
…deep_mind_log

[3.2] simplify deep_mine_tests by replacing complicated merge and match with  straight-forward file copying and comparison
@stephenpdeos
Copy link
Member

Closing based off above references

@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants