You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pick a value that seems somewhat reasonable for read and window time. Or put a comment indicating the default values are just numbers. No need to do in code. Should be in a document.
EOS_ASSERTchain.is_building_block(). No longer applicable as we allow producer in test mode.
calculate_block_deadline is not needed. No longer applicable as the code is refactored to handle read-only trxs in both main thread and read-only threads.
During code walkthrough led by Kevin, the following improvements were suggested. They can be done during RC phases or later.
deque
instead ofstd::deque
. PR [4.0 -> main] Small improvements for parallelizing read-only transactions and tasks #946Would be nice to encapsulate mutex in(moved to Read-only transaction processing - prevent thread starvation while in the read window. #822)_ro_trx_queue
by adding apush/pop
to_ro_trx_queue
.read_window_deadline
so that it is calculated before these are spawning. #PR 901start_recover_keys
may not needed. PR [4.0] Execute read only safe tasks on read-only thread pool #901EOS_ASSERT
chain.is_building_block()
. No longer applicable as we allow producer in test mode.calculate_block_deadline
is not needed. No longer applicable as the code is refactored to handle read-only trxs in both main thread and read-only threads.The text was updated successfully, but these errors were encountered: