[4.0 -> main] Use block_num for interrupt of start_block & Use single timer for read and write windows #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceiving block before beginning of start_block
[3.2] Use block_num for interrupt of start_block
…pt-start-block-4.0
[4.0] Use a single timer for read and write windows
[3.2 -> 4.0] Use block_num for interrupt of start_block
…pt-start-block-main
heifner
changed the title
greg7mdp
approved these changes
Mar 27, 2023
linh2931
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal received block with the block number so that
start_blockcan be interrupted even if the block is received before the start ofstart_block. This is particularly important for #867, but also useful as mitigation against race condition of receiving block right before start of the block in current implementation. See #648.Includes PR: Use a single timer for read and write windows
Read window and write window run exclusively with each other; they do not run at the same time. A single timer is sufficient to control them and makes code simpler.
Merges #893 & #908 & #905 into
main.See #824 for #905
Resolves #891