Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some wasm_interface methods not called by wamsifs on read-only threads #963

Closed
linh2931 opened this issue Apr 4, 2023 · 0 comments · Fixed by #964 or #979
Closed

Some wasm_interface methods not called by wamsifs on read-only threads #963

linh2931 opened this issue Apr 4, 2023 · 0 comments · Fixed by #964 or #979
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap 4.0.0

Comments

@linh2931
Copy link
Member

linh2931 commented Apr 4, 2023 •
edited
Loading

While working on #932 (which will not be merged due to other concerns),

  • I found that code_block_num_last_used, irreversible_block, and wasm_interface_exit were not called by wasmifs on read-only threads.
  • During the review, @heifner found out first_block_num_used field and index were never used in the multi-index container for instantiated modules. This was wasteful.
@linh2931 linh2931 self-assigned this Apr 4, 2023
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Apr 4, 2023
@arhag arhag added 👍 lgtm and removed triage labels Apr 4, 2023
@arhag arhag modified the milestone: Leap 4.0.0 Apr 4, 2023
@linh2931 linh2931 changed the title Some wasm_interface methods not applied on read-only threads Some wasm_interface methods not called by wamsifs on read-only threads Apr 4, 2023
@linh2931 linh2931 mentioned this issue Apr 4, 2023
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Apr 4, 2023
@arhag arhag linked a pull request Apr 5, 2023 that will close this issue
[4.0] Added missing calls to wasmifs on read-only threads #964
Merged
@linh2931 linh2931 mentioned this issue Apr 5, 2023
Merged
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap 4.0.0
3 participants
@arhag @linh2931 @enf-ci-bot