Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] Added missing calls to wasmifs on read-only threads #979

Merged
merged 8 commits into from
Apr 5, 2023
Merged

[4.0 -> main] Added missing calls to wasmifs on read-only threads #979

merged 8 commits into from
Apr 5, 2023

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Apr 5, 2023

Resolved #963
Merge #964 to main.

  • Added missing calls to wasmifs on read-only threads
  • Removed first_block_num_used from wasm_instantiation_cache.emplace
  • Replaced thread_local for wasmifs with a local variable (unordered_map)

@linh2931 linh2931 requested review from heifner and spoonincode April 5, 2023 23:09
@linh2931 linh2931 merged commit ff31742 into main Apr 5, 2023
@linh2931 linh2931 deleted the merge_missing_methods branch April 5, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoonincode spoonincode spoonincode approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some wasm_interface methods not called by wamsifs on read-only threads
3 participants
@linh2931 @heifner @spoonincode