[3.2] Log all http request/response at debug log level #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Apr 11, 2023
| } catch (chain::tx_duplicate& e) { | ||
| error_results results{409, "Conflict", error_results::error_info(e, verbose_http_errors)}; | ||
| cb( 409, fc::time_point::maximum(), fc::variant( results )); | ||
| fc_dlog( logger(), "Duplicate trx while processing ${api}.${call}: ${e}", | ||
| ("api", api_name)("call", call_name)("e", e.to_detail_string()) ); | ||
| } catch (fc::eof_exception& e) { | ||
| error_results results{422, "Unprocessable Entity", error_results::error_info(e, verbose_http_errors)}; |
There was a problem hiding this comment.
Not related to your PR. I am not sure why fc::eof_exception was mapped to 422. The error message said it was "Unable to parse arguments" and used body as arguments. It did not log ("e", e.to_detail_string() like other exceptions.
| stream << req; | ||
| } | ||
| buffer.resize( std::strlen( buffer.data() ) ); | ||
| if( buffer.size() == max_size ) { |
There was a problem hiding this comment.
Should == be >= and truncate buffer between max_size .. buffer.size()?
There was a problem hiding this comment.
buffer.size() can't be greater than max_size.
There was a problem hiding this comment.
Oh, didn't notice buffer was initialized to max_size.
linh2931
approved these changes
Apr 11, 2023
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log all http request and response at
debuglog level. Limit output to 1024 characters to avoid excessive logging.Examples: