fix: not fail on signature checks for dry-run txns #1081
Conversation
| @@ -559,7 +559,7 @@ namespace eosio { namespace chain { | |||
|
|
|||
| } | |||
|
|
|||
| if( !allow_unused_keys || check_but_dont_fail) { | |||
| if( !allow_unused_keys && !check_but_dont_fail) { | |||
There was a problem hiding this comment.
I think the same change should be made at line 548 above, right?
There was a problem hiding this comment.
Thanks.But EOS_ASSERT will only throw the error when the first argument is false. Since check_but_dont_fail should never throw the error when it is true, there is no need to modify at line 548.
There was a problem hiding this comment.
Oh yes, what was I thinking!
| @@ -559,7 +559,7 @@ namespace eosio { namespace chain { | |||
|
|
|||
| } | |||
|
|
|||
| if( !allow_unused_keys || check_but_dont_fail) { | |||
| if( !allow_unused_keys && !check_but_dont_fail) { | |||
| EOS_ASSERT( checker.all_keys_used(), tx_irrelevant_sig, | |||
There was a problem hiding this comment.
Instead, I think the EOS_ASSERT should be modified, since we would ideally want to include the time it takes for checker.all_keys_used()
if( !allow_unused_keys ) {
EOS_ASSERT( checker.all_keys_used() || check_but_dont_fail, tx_irrelevant_sig,
There was a problem hiding this comment.
I have resubmitted the code and updated the PR description
|
Congratulation @PinelliaC on your first Leap PR. Thanks for the PR! |
linh2931
changed the title
|
Changed the PR title. I was surprised initially that read-only trxs called check_authorization. Thanks. |
[3.2] fix: not fail on signature checks for dry-run txns
[3.2 -> 4.0] fix: not fail on signature checks for dry-run txns
[4.0 -> main] fix: not fail on signature checks for dry-run txns
In this method,
check_but_dont_failis equivalent to whether the transaction isdry-run. However, whendry-runistrue, authorization should not be checked.