P2P use round trip of time_message to calculate latency #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o much output for ci/cd.
… sync on a lib notice.
greg7mdp
reviewed
Jun 8, 2023
linh2931
reviewed
Jun 8, 2023
plugins/net_plugin/net_plugin.cpp
Outdated
| void connection::handle_message( const time_message& msg ) { | ||
| peer_ilog( this, "received time_message" ); | ||
| peer_dlog( this, "received time_message: ${t}", ("t", msg) ); |
There was a problem hiding this comment.
Like the change. I was wondering why time_message deserved info log while looking at log files.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
linh2931
approved these changes
Jun 8, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
greg7mdp
reviewed
Jun 8, 2023
This comment was marked as resolved.
This comment was marked as resolved.
greg7mdp
approved these changes
Jun 9, 2023
greg7mdp
reviewed
Jun 9, 2023
greg7mdp
approved these changes
Jun 9, 2023
… not noticed before because handshake would provide it eventually.
…t if we get an unlinkable block
greg7mdp
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address peer review comment: #1215 (comment)
Use round trip time for
time_messagewhich was already implemented. Since this already did a round trip for previous versions of P2P, no new P2P protocol version is needed. All that was needed was to add the calculation and normalize epoch time. Previous versions ofleapdid not specify duration resolution oftime_since_epoch. Some clients returned microsecond values and others returned nanosecond values. Included in this PR is a fix so that allnodeosgoing forward will return nanosecond values even if the resolution is only microseconds.The new latency calculation aggravated some issues introduced by #1215 and that have been around since 4.0, see #1240 which this PR should also fix.
Resolves #1072