[3.1] Test: verify on the correct fork before verifying trx status #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonCalabrese
approved these changes
Sep 9, 2022
oschwaldp-oci
approved these changes
Sep 9, 2022
|
Likely fixes eosnetworkfoundation/mandel#616 you think? |
|
Hmm, no that looks like something different. Do we have logs for that? Or can we get logs for a new run? |
|
I can try some time to reproduce. No rush I will keep that issue open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trx_finality_status_forked_test.pytest purposely introduces a fork to verify trx is forked out and reports the correct state. The failure was for a case when another fork happened after the first fork delaying the time for the trx to reach irreversible.Add verification to the test that the trx is on the expected fork before verifying it is irreversible.
Resolves #127