Disable building leap-dev.deb package by default #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jul 25, 2023
greg7mdp
approved these changes
Jul 25, 2023
|
@spoonincode do you want me to merge this commit, and then catchup the |
|
Either way is/was fine with me; it's more of a "suggest changes" kind of PR that doesn't even require a review for you to decide to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A leap-dev.deb package is currently generated alongside the leap.deb package when performing a
make package(as our README suggests). This leap-dev.deb, similarly to themake dev-installtarget, contains the files required for "native contract unit testing" a.k.a. libtester. afaik we don’t document this leap-dev.deb, nor do we include it as part of leap’s release assets. Instead, it’s used for punting around libtester in various Antelope CI use cases so that leap doesn’t need to always be rebuilt; for example, eos-system-contracts CI uses leap-dev.deb for its unit tests so that it doesn’t need to build leap just to run the system contract unit tests.Unfortunately adding boost to leap-dev.deb is increasing the time it takes to perform
make packagesignificantly: from 30 seconds to 7 minutes. If we leave the README instructions asmake package, it’ll take some users longer to build the .deb packages than building the software!Because the sole use case of leap-dev.deb is Antelope CI usage, disable building leap-dev.deb by default, and just enable it in leap’s CI.