-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The companion Leap PR for using a single execution context per wasm interface #1484
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
36c537f
Use single execution context per wasm interface
linh2931 fc04891
update to the latest eos-vm origin/decouple_exec_ctx branch
linh2931 dd70b9f
Merge branch 'main' into leap_decouple_exec_ctx
linh2931 295bb7c
Merge branch 'main' into leap_decouple_exec_ctx
linh2931 d56e7f6
Merge branch 'main' into leap_decouple_exec_ctx
linh2931 4f17572
bump eos-vm to the head
linh2931 d73fe1b
fix a bad merge from main which missed is_exec_ctx_created_by_backend…
linh2931 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule eos-vm
updated
2 files
+78 −39 | include/eosio/vm/backend.hpp | |
+60 −51 | include/eosio/vm/execution_context.hpp |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was originally worried about the case where the apply options change between apply() calls right here.
For example
reset_max_call_depth()
sets the context's max call depth toinitial_max_call_depth
which was computed based on the options passed when the backend is created,https://github.com/AntelopeIO/eos-vm/blob/8e1d571db99ff1eecd119c299b42886f72ef40b4/include/eosio/vm/backend.hpp#L177-L180
But the max call depth that should be configured at this point in time is what the current options protocol limits are.
But a few lines down from here,
leap/libraries/chain/webassembly/runtimes/eos-vm.cpp
Lines 141 to 147 in 295bb7c
The important part is the
initialize()
call that,https://github.com/AntelopeIO/eos-vm/blob/8e1d571db99ff1eecd119c299b42886f72ef40b4/include/eosio/vm/backend.hpp#L198-L203
seems to set up the context correctly for each apply once
WASM_LIMITS2
is activated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your careful analysis.