Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] enable all tests for Ubuntu 22; NP & LR tests for Ubuntu 18 #173

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

spoonincode
Copy link
Member

Now runs all tests for Ubuntu 20 & 22. Ubuntu 18 still struggles with test_trx_full so leave out its parallel tests but enable NP & LR tests.

I had to touch the parallel-ctest-containers action to fix a problem in Ubuntu 18, so I went ahead and made more changes to it:

  • commit the package-lock.json so that hopefully it's easier to reproduce the minified version of the action. I regret a little committing the obfuscated minimized version but I also feel guilty committing a "large" file in to the repo. It's clearly a leap-specific action so it seems correct to remain in the leap repo. And longer term this should go away since test harness improvements are underway.
  • No longer discover the NP & LR tests during the build job, just have the action find them on their own based on the label.
  • Modify the workflow to only grant package write permission for the sole job that requires it. If there's something evil in that blob of javascript, well, it can't write to the repo or packages.

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Sep 15, 2022
@heifner heifner changed the title enable all tests for Ubuntu 22; NP & LR tests for Ubuntu 18 [3.2] enable all tests for Ubuntu 22; NP & LR tests for Ubuntu 18 Sep 15, 2022
Base automatically changed from ptests_to_hightier to main September 16, 2022 00:52
@spoonincode spoonincode merged commit 5564e9c into main Sep 16, 2022
@spoonincode spoonincode deleted the enable_more_platform_tests branch September 16, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants