Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] automatically create experimental-binaries package on release #1797

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

spoonincode
Copy link
Member

The experimental-binaries package is where we stash away some versioned packages that are not fully supported but we want indefinitely (they would eventually expire as a workflow artifact). Historically we've used this for leap-dev.deb which is used in CI, and ARM packages for DUNE -- both packages we don't fully support thus don't want them highly visible as a release asset.

Now that we're no longer creating ARM packages for DUNE, we can go ahead and automatically create the experimental-binaries package that solely stores leap-dev.deb. This is a rather obtuse procedure that has been done manually so automating it is a great improvement.

Clearly one of the problems with reviewing this is.. how to test it?! I don't have a good answer for that. I developed and tested it manually in a private repo. I think we'll just have to iterate on it if it doesn't work for future releases 😕

I made some changes to asset-artifact-download-action as part of this work -- AntelopeIO/asset-artifact-download-action#4. This got YOLOed merged but we can refine it some more if something comes out of the review. (we want the new wait-for-exact-target feature here so if someone releases before CI is complete at that ref, we wait around for CI to complete so we can upload

⚠️ 5.0 is the first version that has both a ubuntu20 & ubuntu22 leap-dev.deb; this might confuse existing workflows that just install leap-dev*.deb or such -- they might get the package for a different ubuntu version then they're running.

Resolves #1781

file: leap-dev.deb
target: ${{github.sha}}
artifact-name: leap-dev-ubuntu20-amd64
wait-for-exact-target-workflow: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to #1795, fail-on-missing-target: false has been removed. I added that so the workflow would work on 3.x or 4.x or 5.x, but that's not needed since the workflow on the tagged ref is used.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
@spoonincode spoonincode merged commit 5871209 into release/5.0 Oct 23, 2023
21 checks passed
@spoonincode spoonincode deleted the eb_5x branch October 23, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants