Remove thread hop to producer thread for trx signature recovery #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Nov 5, 2023
Comment on lines
819
to
868
| [this, trx{trx}, &chain, time_limit{max_trx_cpu_usage}, trx_type, | ||
| api_trx, is_transient, next{std::move(next)}, return_failure_traces]() mutable { | ||
|
|
||
| transaction_metadata_ptr trx_meta; | ||
| try { | ||
| trx_meta = transaction_metadata::recover_keys( trx, chain.get_chain_id(), time_limit, trx_type, chain.configured_subjective_signature_length_limit() ); | ||
| } catch(...) { | ||
| // use read_write when read is likely fine; this maintains previous behavior of next() always being called from the main thread | ||
| app().executor().post(priority::low, exec_queue::read_write, | ||
| [ex_ptr = std::current_exception(), this, trx{std::move(trx)}, is_transient, next{std::move(next)}]() { | ||
| auto start = fc::time_point::now(); | ||
| auto idle_time = this->_time_tracker.add_idle_time(start); | ||
| auto trx_tracker = this->_time_tracker.start_trx(is_transient, start); | ||
| fc_tlog(_log, "Time since last trx: ${t}us", ("t", idle_time)); | ||
| auto ex_handler = | ||
| [this, is_transient, &next, &trx](fc::exception_ptr ex) { | ||
| this->log_trx_results(trx, nullptr, ex, 0, is_transient); | ||
| next(std::move(ex)); | ||
| }; | ||
| try { | ||
| std::rethrow_exception(ex_ptr); | ||
| } CATCH_AND_CALL(ex_handler) | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| app().executor().post(priority::low, exec_queue::read_write, | ||
| [this, trx_meta{std::move(trx_meta)}, api_trx, is_transient, next{std::move(next)}, return_failure_traces]() mutable { | ||
| auto start = fc::time_point::now(); | ||
| auto idle_time = this->_time_tracker.add_idle_time(start); | ||
| auto trx_tracker = this->_time_tracker.start_trx(is_transient, start); | ||
| fc_tlog(_log, "Time since last trx: ${t}us", ("t", idle_time)); | ||
|
|
||
| auto exception_handler = | ||
| [this, is_transient, &next, &trx_meta](fc::exception_ptr ex) { | ||
| this->log_trx_results(trx_meta->packed_trx(), nullptr, ex, 0, is_transient); | ||
| next(std::move(ex)); | ||
| }; | ||
| try { | ||
| if (!this->process_incoming_transaction_async(trx_meta, api_trx, return_failure_traces, trx_tracker, next)) { | ||
| if (this->in_producing_mode()) { | ||
| this->schedule_maybe_produce_block(true); | ||
| } else { | ||
| this->restart_speculative_block(); | ||
| } | ||
| } | ||
| } | ||
| CATCH_AND_CALL(exception_handler); | ||
| }); | ||
| } ); |
There was a problem hiding this comment.
I think it would be better to remove all occurences of this-> in this code.
linh2931
reviewed
Nov 6, 2023
| }); | ||
| } | ||
| }); | ||
| boost::asio::post( chain.get_thread_pool(), |
There was a problem hiding this comment.
This section of code is deep nested and becomes complicated. Can more comments be added and/or it be refactored a bit?
greg7mdp
approved these changes
Nov 6, 2023
linh2931
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of a
std::futureandwaitin producer thread pool. Now after signature recovery is complete the chain thread posts directly to the main application thread. This improves the eosio token transfer per second (TPS) tests from ~31K TPS to ~36K TPS.Transaction now transitions from net-thread => chain-thread => main-thread.
Removing the thread hop to chain-thread and performing key recovery on the net thread is possible (net-thread => main-thread), but testing shows it easily overwhelms the main-thread. Instead I think we need to create a memory pool of trxs that the main thread can pull from instead of pushing low priority tasks for trx execution to the main thread. That would greatly reduce the contention on the app post call and on the main thread priority queue. See #1860
This builds off the improvement of #1846.
Removes
--producer-threadsoption as there is now no use for the producer thread pool.Issue #1690