Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0 -> main] Prometheus: Ensure valid unique_conn_node_id #1880

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 8, 2023

Make sure a valid and unique connection id is provided to prometheus. If not connected, then use a temporary id until the connection is established and a handshake is received.

Merges release/5.0 into main including #1879

Resolves #1871

@heifner heifner requested review from greg7mdp and linh2931 November 8, 2023 20:53
@heifner heifner added the OCI Work exclusive to OCI team label Nov 8, 2023
@heifner heifner merged commit a6c4f9b into main Nov 8, 2023
29 checks passed
@heifner heifner deleted the GH-1871-prometheus-main branch November 8, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0 prometheus exporter shows stats without a connection id
3 participants