-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Benchmark BLS host functions #1884
Conversation
…rent between benchmarked functions
…osio::chain::transaction_context
… chain->control.get() directly instead
…functions will never reach deadline
… as they are not needed
target_include_directories( benchmark PUBLIC | ||
"${CMAKE_CURRENT_SOURCE_DIR}" | ||
"${CMAKE_CURRENT_BINARY_DIR}/../unittests/include" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to fix this now (or even when merging to main) but we should try to avoid these sort of declarations. We probably want a target similar to eosio_testing_contracts
,
leap/libraries/testing/CMakeLists.txt
Lines 39 to 41 in 581cd2b
configure_file(contracts.hpp.in include/testing_contracts/contracts.hpp ESCAPE_QUOTES) | |
add_library(eosio_testing_contracts INTERFACE) | |
target_include_directories(eosio_testing_contracts INTERFACE ${CMAKE_CURRENT_BINARY_DIR}/include/testing_contracts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spoonincode. I was doing the cleos set code issue yesterday and not getting around with this. As the PR has already merged into 5.0, for cleaner tracking, I will merge the PR to main as is, and use your suggested way later.
Add benchmarking of BLS host functions into
Leap
Benchmark suites. Those host functions are directly benchmarked without using CDT wrappers.Use
benchmark/benchmark -f bls
to benchmark. A sample result looks likeResolves #1854