Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] Adapt to changes in bls12-381 lib and add tests #1939

Merged
merged 37 commits into from
Nov 30, 2023
Merged

[5.0 -> main] Adapt to changes in bls12-381 lib and add tests #1939

merged 37 commits into from
Nov 30, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 30, 2023 •
edited
Loading

Removes host functions:

  • bls_g1_mul
  • bls_g2_mul
  • bls_g1_exp
  • bls_g2_exp

Adds host functions:

  • bls_g1_weighted_sum
  • bls_g2_weighted_sum
  • bls_fp_mul
  • bls_fp_exp

All bls host functions modified to accept and return affine little endian form.

Removes protocol feature: BLS_PRIMITIVES and adds protocol feature BLS_PRIMITIVES2.

Merges release/5.0 into main including #1882 & #1904 & #1938

Resolves #1701

yarkinwho and others added 30 commits November 9, 2023 11:14
@yarkinwho
Make code compile with refactored bls12-381.
71a9319
@yarkinwho
Refactor some interfaces, compiling, not tested yet.
eea0ea3
@yarkinwho
Merge branch 'release/5.0' into yarkin/update_bls
3d188c7
@yarkinwho
Refactor bls_gx calls.
fa59891
@yarkinwho
Add bls_fp_mod and bls_fp_exp
d8dc360
@yarkinwho
Update unit tests.
35f375c
@yarkinwho
Merge branch 'release/5.0' into yarkin/update_bls
77f2be4
@yarkinwho
Fix comile.
9c42d42
@yarkinwho
Update to use affine form instead of jacobian form for data
49d17e3 
serialization.
@yarkinwho
Merge branch 'release/5.0' into yarkin/update_bls
fa5f81e
@yarkinwho
Fix benchmark
4e40590
@linh2931
add benchmarking for Montgomery form host functions
2a85796
@yarkinwho
Add tests for fp_mod, fp_exp, fp_mul
9d35e5a
@yarkinwho
Add more test case and update submodule (only contains test updates).
4255d62
@linh2931
fix weighted sum montgomery form flag
8819030
@linh2931
add const& to std::string parameters in all _impl methods
f280d5e
@yarkinwho
Remove _mont functions.
dfb05c5
@yarkinwho
Update comments.
e1f67e9
@yarkinwho
Delete unused benchmark.
d9e59b8
@linh2931
Merge remote-tracking branch 'origin/yarkin/update_bls' into more_bls…
36eafc7 
…_benchmark
@linh2931
resolve merge conflicts
65b54ab
@linh2931
remove _mont* functions
c39e930
@linh2931
use std::array instead of std::vector to simply conversion to eosio::…
6a9a8b1 
…chain::span
@linh2931
Merge pull request #1904 from AntelopeIO/more_bls_benchmark
cc9bba8 
BLS: add benchmarking for Affine form host functions
@yarkinwho
Update feature signature.
cb4ceaa
@yarkinwho
Update feature manager, fix deep-mind.log accordinglly.
1269951
@yarkinwho
Update to latest bls lib.
11640bf
@yarkinwho
Merge branch 'release/5.0' into yarkin/update_bls
3c5c566
@greg7mdp
remove (multi-exponentiation) from comments.
87738aa
@greg7mdp
Update bls12 submodule to tip of main branch.
804e415
@heifner heifner requested review from greg7mdp and arhag November 30, 2023 16:09
@heifner heifner merged commit 291b6df into main Nov 30, 2023
29 checks passed
@heifner heifner deleted the bls12-381-update-main branch November 30, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify BLS host functions to fix failing tests on ARM builds
5 participants
@heifner @greg7mdp @arhag @yarkinwho @linh2931