Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make EOS VM signal handler less greedy: only handle signals from expected memory range #2322

Merged
merged 4 commits into from
Mar 22, 2024
Merged

make EOS VM signal handler less greedy: only handle signals from expected memory range #2322

merged 4 commits into from
Mar 22, 2024

Conversation

spoonincode
Copy link
Member

Brings AntelopeIO/eos-vm#23. See that PR for full description.

This modification is a theory on behavior seen in #2242: some fault is masquerading as an access violation due to the current greediness of the handlers.

@spoonincode spoonincode requested a review from linh2931 March 18, 2024 20:41
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Update EOS VM signal handler to be less greedy, addressing a condition experienced by a block-producer that resulted in an unlinkable blocks.
Note:end

@spoonincode spoonincode merged commit 421c45a into main Mar 22, 2024
34 checks passed
@spoonincode spoonincode deleted the eosvm_limit_signal_handler branch March 22, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @ericpassmore @greg7mdp @linh2931