[3.2] desubmodule fc #236
Merged
[3.2] desubmodule fc #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Heifner <heifnerk@objectcomputing.com> Co-authored-by: Brian Johnson <johnsonb@objectcomputing.com> Co-authored-by: Areg Hayrapetian <arhag@users.noreply.github.com> Co-authored-by: Daniel Larimer <dan.larimer@block.one> Co-authored-by: Bart Wyatt <bart.wyatt@block.one> Co-authored-by: Matias Romeo <matias.romeo@gmail.com> Co-authored-by: Timothy Banks <timothy.banks@block.one> Co-authored-by: Huang-Ming Huang <huangh@objectcomputing.com> Co-authored-by: Anton Perkov <anton.perkov@block.one> Co-authored-by: Bucky Kittinger <larrykittinger@gmail.com> Co-authored-by: Allen Han <allenhan2@gmail.com> Co-authored-by: Steven Watanabe <steven.watanabe@block.one> Co-authored-by: Nathan Hourt <nat.hourt@gmail.com> Co-authored-by: Jonathan Giszczak <jonrg@hypercubepc.com> Co-authored-by: Jeeyong Um <conr2d@gmail.com> Co-authored-by: Matthieu Vachon <matt@dfuse.io> Co-authored-by: Clayton Calabrese <calabresec@objectcomputing.com> Co-authored-by: Khaled Al-Hassanieh <khaled.alhassanieh@gmail.com> Co-authored-by: johndebord <i@johndebord.tk> Co-authored-by: Todd Fleming <tbfleming@gmail.com> Co-authored-by: Peter Oschwald <oschwaldp@objectcomputing.com> Co-authored-by: Paul Calabrese <calabrep@objectcomputing.com> Co-authored-by: littlekfc <309999096@qq.com> Co-authored-by: Lin Huang <lin.huang@eosnetwork.com> Co-authored-by: Jeffrey Smith II <jeffreyssmith2nd@gmail.com> Co-authored-by: Adam Mitz <mitza@objectcomputing.com> Co-authored-by: Thiago Souza <thiago@elastic.co> Co-authored-by: Chris Gundlach <cgundlach@naughtydawgllc.com> Co-authored-by: zaratustra <zrts@protonmail.com> Co-authored-by: Yue Han <yue.han-ext@block.one> Co-authored-by: Ted Cahall @ EOS Network Foundation <ted@eosn.foundation> Co-authored-by: Tadas <taduxt@gmail.com> Co-authored-by: Steven Strand <steven.strand@block.one> Co-authored-by: Spartucus <spartucus@users.noreply.github.com> Co-authored-by: Phil Mesnier <mesnierp@ociweb.com> Co-authored-by: Pete Cheyne <pete.cheyne@gmail.com> Co-authored-by: Patrick Raphael <patrick.raphael@block.one> Co-authored-by: Kayan <taokayan13@gmail.com> Co-authored-by: Harry Wong <harrywong@live.com> Co-authored-by: anr09 <qiuyu.an@hotmail.com> Co-authored-by: Andrianto Lie <andrianto.lie@block.one>
Closed
larryk85
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's happening: after years of should or shouldn't we, the team has decided to go ahead with desubmoduling fc. Keeping fc a submodule has incurred a lot of overhead with seemingly little benefit -- the use cases for fc outside Leap are vanishingly slim.
Be aware the final commit in this PR makes considerable changes to fc's cmake now that it is no longer a submodule.
Resolves #122