[3.2] manually set PKG_CONFIG_PATH for openssl on macOS #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Sep 28, 2022
| # files may not be found down in the /opt/homebrew/opt directory | ||
| if(APPLE) | ||
| get_filename_component(OPENSSL_LIB_PATH "${OPENSSL_CRYPTO_LIBRARY}" DIRECTORY) | ||
| set(ENV{PKG_CONFIG_PATH} "$ENV{PKG_CONFIG_PATH}:${OPENSSL_LIB_PATH}/pkgconfig") |
There was a problem hiding this comment.
fwiw no problems here empirically with PKG_CONFIG_PATH being empty resulting in a :<path>
heifner
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yubihsm's OpenSSL discovery is via pkg-config instead of find_package. On ARM macOS builds pkg-config is having trouble finding openssl due to nonstandard paths. Let's help it out by manually setting the
PKG_CONFIG_PATHenvironment variable. After this change, provided prerequisite packages are installed via homebrew, one only needs toand macOS builds are operational on both Intel & ARM platforms.
This change is a little icky, but I'm trying not to overthink it as YubiHSM will be removed post 3.2.