Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2 -> main] Clear expired transactions before snapshot and integrity hash #390

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 26, 2022

Clear expired transactions before generating a snapshot or creating an integrity hash. The clear of expired transactions is limited to a deadline during block production, so it is possible there are uncleared transactions because the deadline was hit on the last call to clear. See #290 for more details.

Resolves #290
Merges #366 & #389 into main

@heifner heifner added the OCI Work exclusive to OCI team label Oct 26, 2022
@heifner heifner merged commit f03ac3c into main Oct 26, 2022
@heifner heifner deleted the GH-290-expired-dedup-main branch October 26, 2022 23:22
heifner added a commit that referenced this pull request Aug 7, 2024
heifner added a commit that referenced this pull request Aug 7, 2024
[5.0] P2P: Fix handling of known pending block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure clear_expired_input_transactions has run to completion prior to generating snapshot
2 participants