Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2 -> main] Use error log instead of warning log when resource_monitor exceeds threshold; Changed default error handler to print help in cli apps by default #405

Closed
wants to merge 7 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 29, 2022

[3.2 -> main] Use error log instead of warning log when resource_monitor exceeds threshold

When the resource monitor exceeds its configured threshold, log an error instead of a warning so it is clear that action is needed by the operator.

Resolves #235
Merges #400 & #404 into main


[3.2 -> main] Changed default error handler to print help in cli apps by default

This addresses issue when cli command (such as leap-util or cleos) is being executed with missing/incorrect parameters. Prior behavior displayed error message and exited. This is changed to automatic display of help in a context of existing command/subcommand
Example:

bin/cleos system 
ERROR: RequiredError: A subcommand is required
Send eosio.system contract action to the blockchain.
Usage: bin/cleos system [OPTIONS] SUBCOMMAND

Options:
  -h,--help                   Print this help message and exit
  --help-all                  Show all help


Subcommands:
  newaccount                  Create a new account on the blockchain with initial resources
  regproducer                 Register a new producer
  unregprod                   Unregister an existing producer
  voteproducer                Vote for a producer
  listproducers               List producers
  delegatebw                  Delegate bandwidth
  undelegatebw                Undelegate bandwidth
  listbw                      List delegated bandwidth
  bidname                     Name bidding
  bidnameinfo                 Get bidname info
  buyram                      Buy RAM
  sellram                     Sell RAM
  claimrewards                Claim producer rewards
  regproxy                    Register an account as a proxy (for voting)
  unregproxy                  Unregister an account as a proxy (for voting)
  canceldelay                 Cancel a delayed transaction
  activate                    Activate protocol feature by name
  rex                         Actions related to REX (the resource exchange)

Resolves #318
Merges #371 into main

vladtr and others added 7 commits October 24, 2022 12:46
[3.2] Changed default error handler to print help in cli apps by default
[3.1] Use error log instead of warning log when resource_monitor exceeds threshold
[3.1 -> 3.2] Use error log instead of warning log when resource_monitor exceeds threshold
@heifner heifner changed the title [3.2 -> main] Use error log instead of warning log when resource_monitor exceeds threshold [3.2 -> main] Use error log instead of warning log when resource_monitor exceeds threshold; Changed default error handler to print help in cli apps by default Oct 29, 2022
@heifner heifner closed this Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display help text by default in leap-util print resmon shutdown messages at error priority
2 participants