[3.1] CPack: fix separator in depends field of debian dev pacakge #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable should be separated by commas and not semicolon.
heifner
approved these changes
Nov 1, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to 3.1 of #379. leap-dev.deb is only semi-supported and thus was only being tested in CI on Ubuntu 20.04. Turns out the older cmake in Ubuntu 18.04 did not handle the syntax being used for generating leap-dev.deb's dependencies. This change resolves the syntax to be more in alignment with documented cmake behavior.
Since the original defect was classified as a bug, this change is being backported to stable releases.