Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2 -> main] change the HTTP Server header to be nodeos/keosd version #439

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

spoonincode
Copy link
Member

@spoonincode spoonincode commented Nov 3, 2022

This the main merge of #438

Prior to Leap 3.2, the HTTP server would respond with Server: WebSocket++/0.7.0. In 3.2, the response became Server: Boost.Beast/330 (or potentially some other number based on boost version being used).

Instead, we can set this to the nodeos version, so the response is something like Server: nodeos/v3.2.0-rc2. Besides being more accurate, this may help troubleshoot issues when a user isn't sure what nodeos version they are communicating with.

Resolves #378

@spoonincode spoonincode merged commit bf33fda into main Nov 3, 2022
@spoonincode spoonincode deleted the http_server_header_main branch November 3, 2022 02:02
pnx pushed a commit to eosswedenorg/leap that referenced this pull request Nov 22, 2022
…l_to_fc

move fc::blob to/from_variant out of libchain to fc
pnx pushed a commit to eosswedenorg/leap that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(3.2+) consider setting a more specific HTTP Server header
2 participants