[PH] Provide *PluginArgs dataclasses to capture and validate nodeos config options #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options. Each *PluginArgs dataclass captures the command line argument and default for each option as specificed in nodeos. New test validate_nodeos_plugin_args uses nodeos's --help command to parse out each plugin's available options and defaults to validate current status vs. the *PluginArgs classes. Any addition, removal, update will cause a test failure with note of what has changed. This will allow easy maintenance going forward.
jgiszczak
suggested changes
Dec 6, 2022
BasePluginArgs provides generic implementations of __str__ and supportedNodeosArgs functions for use in each *PluginArgs classes. Update generation script to no longer generate base class functions, but to inherit from base class.
jgiszczak
suggested changes
Dec 7, 2022
tests/performance_tests/NodeosPluginArgs/generate_nodeos_plugin_args_class_files.py
Show resolved
Hide resolved
Also add note to each generated class calling out that it was generated.
jgiszczak
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
*PluginArgsdataclasses to capture and validatenodeosconfig options.Each
*PluginArgsdataclass captures the command line argument and default for each option as specified innodeos.New test
validate_nodeos_plugin_args.pyusesnodeos's--helpcommand to parse out each plugin's available options and defaults to validate current status vs. the*PluginArgsclasses. Any addition, removal, update will cause a test failure with note of what has changed. This will allow easy maintenance going forward.Consequently, quietly defaulted
nodeosarguments will now have representation in the performance harness test reports.