Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PH] Performance Harness csv improvements #647

Merged

Conversation

ClaytonCalabrese
Copy link
Contributor

Adds some additional tracking of block time, and stores it and latency inside as CSV for later consumption.

@oschwaldp-oci oschwaldp-oci self-requested a review January 26, 2023 16:46
@@ -159,6 +165,7 @@ def __init__(self, testHelperConfig: TestHelperConfig=TestHelperConfig(), cluste
self.etcEosioLogsDirPath = self.etcLogsDirPath/Path("eosio")
self.blockDataLogDirPath = self.loggingConfig.logDirPath/Path("blockDataLogs")
self.blockDataPath = self.blockDataLogDirPath/Path("blockData.txt")
self.csvDataPath = self.blockDataLogDirPath/Path("csv.txt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be named more like: transactionMetrics.csv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For file names lets use _ instead of camelCase.

@ClaytonCalabrese ClaytonCalabrese merged commit ac1c5db into feature_performance_harness_stage_2 Jan 27, 2023
@ClaytonCalabrese ClaytonCalabrese deleted the performance_harness_csv branch January 27, 2023 22:18
@oschwaldp-oci oschwaldp-oci added the OCI Work exclusive to OCI team label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants