[PH] Transaction Generator support generating newaccount transactions #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for actionAuthAcct and actionAuthPrivKey for more explicit control when specifying transaction directly. Add actionAuthAcct to json transaction description Add trx generator id to allow differentiation of trx generators for use in create accounts. Factored out set_transaction_headers into own helper function.
Update user data transaction specification to support multiple actions and automatically generating an account namer per transaction to substitute into defined actions using the 'ACCT_PER_TRX' key word. Removed arguments for action data pieces that have been moved into the larger transaction spec in the json files. Added/Updated tests to exercise the new feature.
Default is 90 sec, don't need that long for these tests.
Now that default contract is loaded to eosio again, it teased out a logic error here. Should be 'or' not 'and'.
heifner
requested changes
Feb 10, 2023
ClaytonCalabrese
suggested changes
Feb 11, 2023
ClaytonCalabrese
approved these changes
Feb 13, 2023
heifner
requested changes
Feb 13, 2023
heifner
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand transaction generator to support new account trx
'ACCT_PER_TRX'key word.Additional work: