[3.1 -> main] Fix failure to sync on startup #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Revert reset to lib of sync_next_expected_num in start_sync since it is called outside exclusively starting a new sync. When starting a new sync start from lib.
…u sent them the block or if you are syncing.
[3.1] Fix failure to sync on startup
ndcgundlach
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.0-rc3 included eosnetworkfoundation/mandel#627 which attempted to fix a producer stuck in a coma state. However, the fix was a bit too aggressive and introduced a race-condition on startup syncing.
This PR reverts the aggressive reset of syncing from LIB instead of HEAD for every call to
start_sync. Instead it restarts syncing from LIB only when unlinkable blocks causes a connection to be closed. This should still fix the issue of eosnetworkfoundation/mandel#623 without causing the problem seen in #49.Resolves #49