[PH] Resolve Duplicate Transaction ID Generation in Transaction Generator #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwaldp-oci
approved these changes
Feb 27, 2023
ClaytonCalabrese
deleted the
performance_harness_resolve_duplicate_transaction_ids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate transaction IDs were possible to be generated by two different transaction generators creating transactions at the same time (epoch). This was more likely if the
Action Dataspecified was blank, so it was mainly affecting thecpuandramperformance tests. This PR adds the transaction generator's_generator_idto the context free actions to prevent collision from happening in the future.It also does a little rewrite of a loop to make it more readable.