[3.1] patch pinned build's boost 1.70 to fix websocket defect #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 1, 2022
heifner
pushed a commit
that referenced
this pull request
Apr 29, 2024
fix a few small compile warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pinned builds will use boost 1.70 for the entirety of 3.x's lifecycle. boost 1.70 shipped with a defect in beast's websocket implementation that can lead to crashes. Can read more here,
The patch included with this PR to fix the issue is linked directly from boost's release notes for 1.70 so it seems to be a well supported fix
https://www.boost.org/users/history/version_1_70_0.html
The only component in Leap that uses websockets is the state history plugin and we caution users to only expose that websocket endpoint to internal trusted clients, so this fix isn't being fast tracked.
Resolves eosnetworkfoundation/mandel#816