Simplify condition variable use #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Mar 22, 2023
| void set_exit_criteria(uint32_t num_tasks, std::atomic<bool>* received_block, fc::time_point deadline) { | ||
| assert(num_tasks > 0 && num_waiting == 0); | ||
| void set_exit_criteria(uint32_t num_tasks, std::atomic<bool>* received_block, const fc::time_point& deadline) { | ||
| std::lock_guard<std::mutex> g( mtx ); |
There was a problem hiding this comment.
std::lock_guard unnecessary as this is called from a single thread
There was a problem hiding this comment.
True, but safer to have here in case this code is called from somewhere else. A uncontested lock is not very expensive.
| @@ -473,34 +464,27 @@ class producer_plugin_impl : public std::enable_shared_from_this<producer_plugin | |||
| // - all threads would be idle | |||
| // - or the net_plugin received a block. | |||
| // - or we have reached the read_window_deadline | |||
| void set_exit_criteria(uint32_t num_tasks, std::atomic<bool>* received_block, fc::time_point deadline) { | |||
| assert(num_tasks > 0 && num_waiting == 0); | |||
| void set_exit_criteria(uint32_t num_tasks, std::atomic<bool>* received_block, const fc::time_point& deadline) { | |||
There was a problem hiding this comment.
I think it is better to pass deadline by value https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-in
|
Comments are being included into #844 |
linh2931
reviewed
Mar 22, 2023
|
|
||
| ++num_waiting; | ||
| cond.wait(g, [this]() { | ||
| return !queue.empty() || should_exit(); |
There was a problem hiding this comment.
I like this. Earlier I was worried when switching from write window, we might end up waiting forever in some corner cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.